Fix deploy site workflow#2113
Merged
doug-walker merged 2 commits intoApr 3, 2025
Merged
Conversation
Signed-off-by: Zach Lewis <zachcanbereached@gmail.com>
zachlewis
force-pushed
the
fix_deploy_site_workflow
branch
from
a541b58 to
061f231
Compare
Collaborator
|
@zachlewis , currently the original OCIO v1 website is being maintained as part of the site at this link. We reference it on the landing page of the documentation here. Since that is in the gh_pages branch, and is not generated from Hugo, I'm guessing that would be dropped. Am I correct? At this point, I'm not sure we still need to preserve the old website. Any opinions on that? |
Collaborator
Author
|
Ah, yes, I forgot to mention that. You are correct, we would no longer be preserving the old site with this workflow. If that's a concern, we can work something else out that still uses the "classic" gh-pages branch method. |
Collaborator
|
I think we can say goodbye to our old site and remove the link :)
…On Mon, Jan 20, 2025 at 14:04 zachlewis ***@***.***> wrote:
Ah, yes, I forgot to mention that. You are correct, we would no longer be
preserving the old site with this workflow. If that's a concern, we can
work something else out that still uses the "classic" gh-pages branch
method.
—
Reply to this email directly, view it on GitHub
<#2113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMPHU2GZ3KONSWHLI357EFT2LVXGZAVCNFSM6AAAAABVQ65JWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBTGI4DMMZVGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
remia
approved these changes
Feb 4, 2025
doug-walker
merged commit aaa4a79
into
AcademySoftwareFoundation:main
20 of 24 checks passed
Collaborator
|
This seems to be working beautifully, thank you @zachlewis ! |
Collaborator
|
Amazing, thanks both for getting this working! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New and improved github workflow for building and deploying our Hugo-based site.
Instead of maintaining a "gh-pages" branch, this workflow uses the preferred "deploy-site" GH action. This requires updating the repo settings (Code and Automation > Pages > Build and Deploy) to use the workflow-based deployment settings, as opposed to the classic branch-based deployment settings.
(NB: I've already updated the repo settings in anticipation of merging this PR).
Also, I haven't thoroughly tested this. The workflow is based on github's template for building and deploying Hugo sites, but if something goes wrong... well... I'll try again with another PR!